Topic on User talk:U+1F360

Jump to navigation Jump to search

Bot matching neighborhood to railway station

4
Pi.1415926535 (talkcontribs)

Your bot has made some edits recently that assign Who's On First IDs to railway stations that share their name with a neighborhood. See for example here. It would be best to have the bot check the instance of (P31) statement to make sure that it's a geographic entity - and not a railway station or other incorrect match - before adding. Thanks, Pi.1415926535 (talk) 08:41, 28 August 2019 (UTC)

U+1F360 (talkcontribs)

The problem with this record is that it is incorrect upstream. I've submitted a pull request to fix it. Unfortunately, Who's on First covers instances of venue (Q17350442), which this item is. I will add a check to ensure that the bot does not edit the same item more than once, so this shouldn't happen to this item again.

Pi.1415926535 (talkcontribs)

The error has happened a number of times. The bot made the same error (matching a neighborhood on Who's On First to a railway station on Wikidata) on Q5033899, Q5361212, Q7958780, Q5432066, Q3467065, Q6986546, and Q7985399 - and that's just the ones I happened to be watching. Does the bot not check that the Who's On First item and the Wikidata item are the same type?

U+1F360 (talkcontribs)

ok, that's an interesting idea... we could map the placetypes to Wikidata items. To answer your question, no, it doesn't check, because there isn't a mapping, but I could create that (and I don't see why it couldn't live in their repo). I think that would fix the problem?